Boot Contract type from Budget #1501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is an alternative to #1481. We should go with one or the other, but not both. |
In the old bank (before the contract engine), Contract wasn't specific to Budget. It provided the same service as what is now called SystemProgram::Move, but without requiring a separate account.
Debits no longer need to be applied before credits. Instead, we lock any accounts we'd debit and so error out on the second attempt to lock the same account.
Budget now assumes the source account holds all tokens the program should spend. Note: the static guarantees implied by verify_plan() are meaningless under the new contract engine. The bank no longer calls it. This serves as a nice example of where comparing code coverage between integration tests and unit tests would have shown us where a change rendered unit tests meaningless.
garious
force-pushed
the
boot-contract
branch
from
0d491ab
to
19c71b3
Compare
The test is showing how you can sneak by verify_plan() but not verify_signature().
Closed
mvines
approved these changes
Oct 18, 2018
wen-coding
pushed a commit
to wen-coding/solana
that referenced
this pull request
May 28, 2024
Typo in `solana-keygen grind`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the old bank (before the contract engine), Contract wasn't specific
to Budget. It provided the same service as what is now called
SystemProgram::Move, but without requiring a separate account.
This PR migrates to SystemProgram::Move so that the client doesn't need to trust
BudgetProgram.