increases timeout duration for gossip discover #17408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behzadnouri
force-pushed
the
discover-fail
branch
2 times, most recently
from
0953aa5
to
9a3d61f
Compare
behzadnouri
force-pushed
the
discover-fail
branch
from
9a3d61f
to
403f545
Compare
Codecov Report
@@ Coverage Diff @@
## master #17408 +/- ##
=========================================
- Coverage 82.7% 82.7% -0.1%
=========================================
Files 424 424
Lines 118634 118634
=========================================
- Hits 98216 98191 -25
- Misses 20418 20443 +25 |
mergify bot
added a commit
that referenced
this pull request
May 22, 2021
) * increases timeout duration for gossip discover (cherry picked from commit d649637) * uses Duration type for gossip discover timeout (cherry picked from commit cf1acfb) # Conflicts: # core/src/gossip_service.rs * removes backport merge conflicts Co-authored-by: behzad nouri <behzadnouri@gmail.com>
behzadnouri
added a commit
to behzadnouri/solana
that referenced
this pull request
May 23, 2021
coverage ci builds are failing presumably because of the overhead added in: solana-labs#17236 for very small test cluster. Previous attempt at fixing the flakiness: solana-labs#17408 This commit uses smaller min number of bloom items condition on that if debug assertions are enabled or not.
behzadnouri
added a commit
to behzadnouri/solana
that referenced
this pull request
May 23, 2021
coverage ci builds are have become flaky presumably because of the overhead added in solana-labs#17236 for very small test clusters. This commit uses a smaller min number of bloom items condition on that if debug assertions are enabled or not. Previous attempt at fixing the flakiness: solana-labs#17408
mergify bot
pushed a commit
that referenced
this pull request
May 23, 2021
coverage ci builds are have become flaky presumably because of the overhead added in #17236 for very small test clusters. This commit uses a smaller min number of bloom items condition on that if debug assertions are enabled or not. Previous attempt at fixing the flakiness: #17408 (cherry picked from commit 5567305)
mergify bot
added a commit
that referenced
this pull request
May 23, 2021
coverage ci builds are have become flaky presumably because of the overhead added in #17236 for very small test clusters. This commit uses a smaller min number of bloom items condition on that if debug assertions are enabled or not. Previous attempt at fixing the flakiness: #17408 (cherry picked from commit 5567305) Co-authored-by: behzad nouri <behzadnouri@gmail.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#17236 increased default number of bloom items when making gossip
pull-requests. The change is effectively a no-op once a validator syncs
to a real cluster as the number of items will already become larger than
the default value there.
However, it adds overhead to tests with a very small cluster, and
results in
dicover_clustertimeouts in tests.Summary of Changes
discover_cluster.Durationtype for timeout (type-safety and self-documenting unit).