Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use cross-fetch instead of node-fetch #19621

Merged
merged 1 commit into from Sep 7, 2021

Conversation

@jstarry
Copy link
Member

@jstarry jstarry commented Sep 3, 2021

Problem

New version of node-fetch no longer includes browser module

Summary of Changes

  • Bump min node version to v12.20.0 from v11
  • Use cross-fetch instead of using node-fetch directly
  • Silence a few new rollup warnings
  • Add explicit required node version

Fixes #

@jstarry jstarry requested a review from oJshua Sep 3, 2021
@codecov
Copy link

@codecov codecov bot commented Sep 3, 2021

Codecov Report

Merging #19621 (b79cf16) into master (bbc4fdb) will decrease coverage by 11.3%.
The diff coverage is 100.0%.

@@             Coverage Diff             @@
##           master   #19621       +/-   ##
===========================================
- Coverage    82.5%    71.1%    -11.4%     
===========================================
  Files         468       34      -434     
  Lines      131676     1995   -129681     
  Branches        0      280      +280     
===========================================
- Hits       108686     1420   -107266     
+ Misses      22990      477    -22513     
- Partials        0       98       +98     

oJshua
oJshua approved these changes Sep 7, 2021
@jstarry jstarry merged commit 4c6f9ba into solana-labs:master Sep 7, 2021
6 checks passed
@jstarry jstarry deleted the cross-fetch branch Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants