Prevent rent-paying account creation #22292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CriesofCarrots
changed the title
CriesofCarrots
force-pushed
the
prevent-rent-paying-account-creation
branch
2 times, most recently
from
58926e0
to
9f4918f
Compare
|
@jstarry , can you please start looking at this when you have a minute? (There are a bunch of tests that assume it's okay to create rent-paying accounts, so still lots of fixup before formally ready) To answer your question from here (#21142 (comment), and I'm sorry for taking so long to do so!), I prefer this location because this is where the execution result is still being determined, ie. mutable. This actually seems even more stark to me after your refactor; the execution result should be set and unmutable after Also, in order to allow legacy rent-paying accounts, we need to know the state before execution, which will be clunky to pass along to (edit) However, your point about only examining writable accounts is a fair one. Added a commit to do this. Could potentially remove the |
CriesofCarrots
force-pushed
the
prevent-rent-paying-account-creation
branch
2 times, most recently
from
c02d320
to
f0eb930
Compare
jstarry
reviewed
Jan 6, 2022
jstarry
reviewed
Jan 6, 2022
jstarry
reviewed
Jan 6, 2022
jstarry
reviewed
Jan 6, 2022
CriesofCarrots
force-pushed
the
prevent-rent-paying-account-creation
branch
9 times, most recently
from
0fd398e
to
de7e748
Compare
|
Less the assert, this is ready for real review! All the test churn should be confined to the one commit "Fix rpc tests...", so feel free to ignore that one. |
CriesofCarrots
force-pushed
the
prevent-rent-paying-account-creation
branch
from
de7e748
to
00c5873
Compare
jstarry
previously approved these changes
Jan 8, 2022
CriesofCarrots
force-pushed
the
prevent-rent-paying-account-creation
branch
from
00c5873
to
40145c3
Compare
This was referenced Jan 8, 2022
|
i'll keep my eyes on this. maybe we need to advice all exchanges/wallets beforehand about this upcoming change as this will forbid these kinds of affected small SOL transfers. (anyway, these transfers should be erroneous to begin with). how about adding a small section here: docs/src/integrations/exchange.md (or, i can do as a follow-up). |
ryoqun
reviewed
Jan 10, 2022
behzadnouri
added a commit
to behzadnouri/solana
that referenced
this pull request
Jul 7, 2022
solana-labs#22292 prevents rent paying account creation going forward. As a result rent_epoch field for rent exempt accounts is redundant, and advancing this field will incur expensive account rewrites and cause discrepancy between accounts-db and cached vote/stake accounts. This commit adds a feature which upon activation preserves rent_epoch field for rent exempt accounts so that the field is frozen and is no longer advanced.
behzadnouri
added a commit
to behzadnouri/solana
that referenced
this pull request
Jul 8, 2022
solana-labs#22292 prevents rent paying account creation going forward. As a result rent_epoch field for rent exempt accounts is redundant, and advancing this field will incur expensive account rewrites and cause discrepancy between accounts-db and cached vote/stake accounts. This commit adds a feature which upon activation preserves rent_epoch field for rent exempt accounts so that the field is frozen and is no longer advanced.
behzadnouri
added a commit
to behzadnouri/solana
that referenced
this pull request
Jul 8, 2022
solana-labs#22292 prevents rent paying account creation going forward. As a result rent_epoch field for rent exempt accounts is redundant, and advancing this field will incur expensive account rewrites and cause discrepancy between accounts-db and cached vote/stake accounts. This commit adds a feature which upon activation preserves rent_epoch field for rent exempt accounts so that the field is frozen and is no longer advanced.
behzadnouri
added a commit
to behzadnouri/solana
that referenced
this pull request
Jul 8, 2022
solana-labs#22292 prevents rent paying account creation going forward. As a result rent_epoch field for rent exempt accounts is redundant, and advancing this field will incur expensive account rewrites and cause discrepancy between accounts-db and cached vote/stake accounts. This commit adds a feature which upon activation preserves rent_epoch field for rent exempt accounts so that the field is frozen and is no longer advanced.
behzadnouri
added a commit
that referenced
this pull request
Jul 8, 2022
#22292 prevents rent paying account creation going forward. As a result rent_epoch field for rent exempt accounts is redundant, and advancing this field will incur expensive account rewrites and cause discrepancy between accounts-db and cached vote/stake accounts. This commit adds a feature which upon activation preserves rent_epoch field for rent exempt accounts so that the field is frozen and is no longer advanced.
mergify bot
pushed a commit
that referenced
this pull request
Jul 8, 2022
#22292 prevents rent paying account creation going forward. As a result rent_epoch field for rent exempt accounts is redundant, and advancing this field will incur expensive account rewrites and cause discrepancy between accounts-db and cached vote/stake accounts. This commit adds a feature which upon activation preserves rent_epoch field for rent exempt accounts so that the field is frozen and is no longer advanced. (cherry picked from commit c99d9f0) # Conflicts: # runtime/src/accounts.rs # runtime/src/bank.rs # runtime/src/expected_rent_collection.rs # runtime/src/rent_collector.rs
behzadnouri
added a commit
that referenced
this pull request
Jul 10, 2022
#22292 prevents rent paying account creation going forward. As a result rent_epoch field for rent exempt accounts is redundant, and advancing this field will incur expensive account rewrites and cause discrepancy between accounts-db and cached vote/stake accounts. This commit adds a feature which upon activation preserves rent_epoch field for rent exempt accounts so that the field is frozen and is no longer advanced. (cherry picked from commit c99d9f0)
mergify bot
added a commit
that referenced
this pull request
Jul 10, 2022
* names fields in RentResullt::CollectRent enum variant (#26449) Avoiding ambiguous raw tuple: CollectRent((Epoch, u64)) Using named fields instead: CollectRent { new_rent_epoch: Epoch, rent_due: u64, }, (cherry picked from commit d7201a8) # Conflicts: # runtime/src/bank.rs # runtime/src/expected_rent_collection.rs # runtime/src/rent_collector.rs * removes mergify merge conflicts * preserves rent_epoch for rent exempt accounts (#26479) #22292 prevents rent paying account creation going forward. As a result rent_epoch field for rent exempt accounts is redundant, and advancing this field will incur expensive account rewrites and cause discrepancy between accounts-db and cached vote/stake accounts. This commit adds a feature which upon activation preserves rent_epoch field for rent exempt accounts so that the field is frozen and is no longer advanced. (cherry picked from commit c99d9f0) Co-authored-by: behzad nouri <behzadnouri@gmail.com>
behzadnouri
added a commit
to behzadnouri/solana
that referenced
this pull request
Jul 13, 2022
behzadnouri
added a commit
to behzadnouri/solana
that referenced
this pull request
Jul 13, 2022
solana-labs#22292 prevents rent paying accounts creation going forward. However a rent paying account can linger on for ever if it is continually topped up but stays below the rent-exempt minimum. This can prevent eliminating accounts-rewrites and the problematic rent_epoch field in accounts. This commit restricts rent-paying accounts TTL extension by preventing increasing lamports on the account if the account stays below the rent-exempt minimum.
behzadnouri
added a commit
to behzadnouri/solana
that referenced
this pull request
Jul 13, 2022
solana-labs#22292 prevents rent paying accounts creation going forward. However a rent paying account can linger on for ever if it is continually topped up but stays below the rent-exempt minimum. This can prevent eliminating accounts-rewrites and the problematic rent_epoch field in accounts. Link to discord discussion: https://discord.com/channels/428295358100013066/943609352068145162/995202300001927219 This commit restricts rent-paying accounts TTL extension by preventing increasing lamports on the account if the account stays below the rent-exempt minimum.
This was referenced Jul 13, 2022
behzadnouri
added a commit
to behzadnouri/solana
that referenced
this pull request
Jul 13, 2022
solana-labs#22292 prevents rent paying accounts creation going forward. However a rent paying account can linger on for ever if it is continually topped up but stays below the rent-exempt minimum. This can prevent eliminating accounts-rewrites and the problematic rent_epoch field in accounts. Link to discord discussion: https://discord.com/channels/428295358100013066/943609352068145162/995202300001927219 This commit restricts rent-paying accounts TTL extension by preventing increasing lamports on the account if the account stays below the rent-exempt minimum.
behzadnouri
added a commit
to behzadnouri/solana
that referenced
this pull request
Jul 13, 2022
solana-labs#22292 prevents rent paying accounts creation going forward. However a rent paying account can linger on for ever if it is continually topped up but stays below the rent-exempt minimum. This can prevent eliminating accounts-rewrites and the problematic rent_epoch field in accounts. Link to discord discussion: https://discord.com/channels/428295358100013066/943609352068145162/995202300001927219 This commit restricts rent-paying accounts lifeline extension by preventing increasing lamports on the account if the account stays below the rent-exempt minimum.
behzadnouri
added a commit
to behzadnouri/solana
that referenced
this pull request
Jul 14, 2022
solana-labs#22292 prevents rent paying accounts creation going forward. However a rent paying account can linger on for ever if it is continually topped up but stays below the rent-exempt minimum. This can prevent eliminating accounts-rewrites and the problematic rent_epoch field in accounts. Link to discord discussion: https://discord.com/channels/428295358100013066/943609352068145162/995202300001927219 This commit restricts rent-paying accounts lifeline extension by preventing increasing lamports on the account if the account stays below the rent-exempt minimum.
behzadnouri
added a commit
to behzadnouri/solana
that referenced
this pull request
Jul 14, 2022
solana-labs#22292 prevents rent paying accounts creation going forward. However a rent paying account can linger on for ever if it is continually topped up but stays below the rent-exempt minimum. This can prevent eliminating accounts-rewrites and the problematic rent_epoch field in accounts. Link to discord discussion: https://discord.com/channels/428295358100013066/943609352068145162/995202300001927219 This commit restricts rent-paying accounts lifeline extension by preventing increasing lamports on the account if the account stays below the rent-exempt minimum.
behzadnouri
added a commit
to behzadnouri/solana
that referenced
this pull request
Jul 14, 2022
solana-labs#22292 prevents rent paying accounts creation going forward. However a rent paying account can linger on for ever if it is continually topped up but stays below the rent-exempt minimum. This can prevent eliminating accounts-rewrites and the problematic rent_epoch field in accounts. Link to discord discussion: https://discord.com/channels/428295358100013066/943609352068145162/995202300001927219 This commit restricts rent-paying accounts lifeline extension by preventing increasing lamports on the account if the account stays below the rent-exempt minimum.
behzadnouri
added a commit
to behzadnouri/solana
that referenced
this pull request
Jul 14, 2022
solana-labs#22292 prevents rent paying accounts creation going forward. However a rent paying account can linger on for ever if it is continually topped up but stays below the rent-exempt minimum. This can prevent eliminating accounts-rewrites and the problematic rent_epoch field in accounts. Link to discord discussion: https://discord.com/channels/428295358100013066/943609352068145162/995202300001927219 This commit restricts rent-paying accounts lifeline extension by preventing increasing lamports on the account if the account stays below the rent-exempt minimum.
behzadnouri
added a commit
to behzadnouri/solana
that referenced
this pull request
Jul 15, 2022
solana-labs#22292 prevents rent paying accounts creation going forward. However a rent paying account can linger on for ever if it is continually topped up but stays below the rent-exempt minimum. This can prevent eliminating accounts-rewrites and the problematic rent_epoch field in accounts. Link to discord discussion: https://discord.com/channels/428295358100013066/943609352068145162/995202300001927219 This commit restricts rent-paying accounts lifeline extension by preventing increasing lamports on the account if the account stays below the rent-exempt minimum.
behzadnouri
added a commit
that referenced
this pull request
Jul 15, 2022
#22292 prevents rent paying accounts creation going forward. However a rent paying account can linger on for ever if it is continually topped up but stays below the rent-exempt minimum. This can prevent eliminating accounts-rewrites and the problematic rent_epoch field in accounts. Link to discord discussion: https://discord.com/channels/428295358100013066/943609352068145162/995202300001927219 This commit restricts rent-paying accounts lifetime extension by preventing increasing lamports on the account if the account stays below the rent-exempt minimum.
mergify bot
pushed a commit
that referenced
this pull request
Jul 15, 2022
#22292 prevents rent paying accounts creation going forward. However a rent paying account can linger on for ever if it is continually topped up but stays below the rent-exempt minimum. This can prevent eliminating accounts-rewrites and the problematic rent_epoch field in accounts. Link to discord discussion: https://discord.com/channels/428295358100013066/943609352068145162/995202300001927219 This commit restricts rent-paying accounts lifetime extension by preventing increasing lamports on the account if the account stays below the rent-exempt minimum. (cherry picked from commit bf225ba) # Conflicts: # runtime/src/account_rent_state.rs # runtime/src/accounts.rs # runtime/src/bank/transaction_account_state_info.rs # sdk/src/feature_set.rs
mergify bot
added a commit
that referenced
this pull request
Jul 15, 2022
…26635) * restricts rent-paying accounts lifetime extension (#26606) #22292 prevents rent paying accounts creation going forward. However a rent paying account can linger on for ever if it is continually topped up but stays below the rent-exempt minimum. This can prevent eliminating accounts-rewrites and the problematic rent_epoch field in accounts. Link to discord discussion: https://discord.com/channels/428295358100013066/943609352068145162/995202300001927219 This commit restricts rent-paying accounts lifetime extension by preventing increasing lamports on the account if the account stays below the rent-exempt minimum. (cherry picked from commit bf225ba) # Conflicts: # runtime/src/account_rent_state.rs # runtime/src/accounts.rs # runtime/src/bank/transaction_account_state_info.rs # sdk/src/feature_set.rs * removes mergify merge conflicts Co-authored-by: behzad nouri <behzadnouri@gmail.com>
Lcchy
pushed a commit
to Bonfida/solana
that referenced
this pull request
Jul 22, 2022
solana-labs#22292 prevents rent paying accounts creation going forward. However a rent paying account can linger on for ever if it is continually topped up but stays below the rent-exempt minimum. This can prevent eliminating accounts-rewrites and the problematic rent_epoch field in accounts. Link to discord discussion: https://discord.com/channels/428295358100013066/943609352068145162/995202300001927219 This commit restricts rent-paying accounts lifetime extension by preventing increasing lamports on the account if the account stays below the rent-exempt minimum.
This was referenced Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
A single epoch's worth of rent for an account with data is too little relative to the costs of storing that data.
Summary of Changes
Compare rent-exemption status pre- and post-processing; fail if any end up RentPaying that didn't start that way.
Closes #21142