Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpi charge for executables #24396

Merged
merged 1 commit into from Apr 20, 2022

Conversation

jackcmay
Copy link
Contributor

@jackcmay jackcmay commented Apr 15, 2022

Problem

Accounts sent via CPI are charged a per-data compute cost, but executables are not

Summary of Changes

Charge executables

Fixes #
Feature Gate Issue: #24512

@jackcmay jackcmay requested a review from Lichtso April 15, 2022 20:39
Lichtso
Lichtso previously approved these changes Apr 15, 2022
@jstarry
Copy link
Member

jstarry commented Apr 16, 2022

Please create a feature tracker issue for this!

@jstarry jstarry added the feature-gate Pull Request adds or modifies a runtime feature gate label Apr 16, 2022
@jackcmay
Copy link
Contributor Author

@jstarry Yup, was planning on it, its a tentative change at the moment

@mergify mergify bot dismissed Lichtso’s stale review April 20, 2022 00:22

Pull request has been modified.

@codecov
Copy link

codecov bot commented Apr 20, 2022

Codecov Report

Merging #24396 (783ccc5) into master (255a6a7) will decrease coverage by 0.0%.
The diff coverage is 14.2%.

@@            Coverage Diff            @@
##           master   #24396     +/-   ##
=========================================
- Coverage    82.0%    81.9%   -0.1%     
=========================================
  Files         593      593             
  Lines      163827   163834      +7     
=========================================
- Hits       134340   134294     -46     
- Misses      29487    29540     +53     

@jackcmay jackcmay merged commit 5eb1ba4 into solana-labs:master Apr 20, 2022
@jackcmay jackcmay deleted the charge-for-executables branch April 20, 2022 02:31
@jackcmay jackcmay added the v1.10 label Jun 6, 2022
mergify bot pushed a commit that referenced this pull request Jun 6, 2022
(cherry picked from commit 5eb1ba4)

# Conflicts:
#	programs/bpf_loader/src/syscalls.rs
#	sdk/src/feature_set.rs
@jackcmay jackcmay added v1.10 and removed v1.10 labels Jun 6, 2022
mergify bot added a commit that referenced this pull request Jun 6, 2022
* cpi charge for executables (#24396)

(cherry picked from commit 5eb1ba4)

# Conflicts:
#	programs/bpf_loader/src/syscalls.rs
#	sdk/src/feature_set.rs

* resolve conflicts

Co-authored-by: Jack May <jack@solana.com>
jeffwashington pushed a commit to jeffwashington/solana that referenced this pull request Jun 29, 2022
jeffwashington pushed a commit to jeffwashington/solana that referenced this pull request Jun 30, 2022
jeffwashington pushed a commit to jeffwashington/solana that referenced this pull request Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-gate Pull Request adds or modifies a runtime feature gate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants