New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cpi charge for executables #24396
Merged
Merged
cpi charge for executables #24396
+16
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lichtso
previously approved these changes
Apr 15, 2022
Please create a feature tracker issue for this! |
jstarry
added
the
feature-gate
Pull Request adds or modifies a runtime feature gate
label
Apr 16, 2022
@jstarry Yup, was planning on it, its a tentative change at the moment |
jackcmay
force-pushed
the
charge-for-executables
branch
from
April 20, 2022 00:21
1623116
to
783ccc5
Compare
Codecov Report
@@ Coverage Diff @@
## master #24396 +/- ##
=========================================
- Coverage 82.0% 81.9% -0.1%
=========================================
Files 593 593
Lines 163827 163834 +7
=========================================
- Hits 134340 134294 -46
- Misses 29487 29540 +53 |
mergify bot
pushed a commit
that referenced
this pull request
Jun 6, 2022
(cherry picked from commit 5eb1ba4) # Conflicts: # programs/bpf_loader/src/syscalls.rs # sdk/src/feature_set.rs
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 29, 2022
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 30, 2022
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Accounts sent via CPI are charged a per-data compute cost, but executables are not
Summary of Changes
Charge executables
Fixes #
Feature Gate Issue: #24512