ledger-tool: save new snapshots to --snapshot-archive-path #24883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for fixing this. I guess it would be nice to have cli test at least for this case. |
Codecov Report
@@ Coverage Diff @@
## master #24883 +/- ##
=========================================
+ Coverage 81.8% 82.0% +0.1%
=========================================
Files 632 597 -35
Lines 167499 165701 -1798
Branches 322 0 -322
=========================================
- Hits 137169 135990 -1179
+ Misses 30217 29711 -506
+ Partials 113 0 -113 |
CriesofCarrots
approved these changes
May 2, 2022
There was a problem hiding this comment.
Looks good to me. Thanks for fixing this @diman-io!
I agree that tests in this crate would be nice. But since there isn't a solana-ledger-tool testing framework yet, let's address that post-merge @KirillLykov .
mergify bot
pushed a commit
that referenced
this pull request
May 2, 2022
(cherry picked from commit 8846aa1)
mergify bot
pushed a commit
that referenced
this pull request
May 2, 2022
(cherry picked from commit 8846aa1)
I've created an issue for that #24927 |
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Ledger-tool doesn't save new snapshots to --snapshot-archive-path #24875
Summary of Changes
Fixed behavior when choosing an
output-dirforcreate-snapshotcommand.If
output-diris not specified in args then it will be--snapshot-archive-pathif present, otherwise--ledger. Before this fix,--snapshot-archive-pathwas not checked.Fixes #24875