Introduces Result return types to mutable accessors of BorrowedAccount
#25380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…data_length() of BorrowedAccount.
…_executable() of BorrowedAccount.
jstarry
approved these changes
May 21, 2022
behzadnouri
added a commit
that referenced
this pull request
May 22, 2022
behzadnouri
added a commit
that referenced
this pull request
May 23, 2022
|
@behzadnouri Yes, the |
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 29, 2022
…ount` (solana-labs#25380) * Introduces result return types to get_data_mut(), set_data() and set_data_length() of BorrowedAccount. * Introduces result return types to set_owner(), set_lamports() and set_executable() of BorrowedAccount.
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 29, 2022
This partially reverts commit f884203. Apparently CI runs for solana-labs#25380 solana-labs#25429 have interleaved each other resulting in a broken master.
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 29, 2022
…ount` (solana-labs#25380) * Introduces result return types to get_data_mut(), set_data() and set_data_length() of BorrowedAccount. * Introduces result return types to set_owner(), set_lamports() and set_executable() of BorrowedAccount.
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 29, 2022
This partially reverts commit f884203. Apparently CI runs for solana-labs#25380 solana-labs#25429 have interleaved each other resulting in a broken master.
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 29, 2022
This partially reverts commit f884203. Apparently CI runs for solana-labs#25380 solana-labs#25429 have interleaved each other resulting in a broken master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Instead of
PreAccountcatching misbehavior after the instruction finishes,we want to call it out immediately, when it happens.
This is a preparation to throw errors on faulty access.
Summary of Changes
Introduces
Resultreturn types to the following methods ofBorrowedAccount:get_data_mut()set_data()set_data_length()set_owner()set_lamports()set_executable()And always return
Ok()for now, the actual feature gated check comes later.