Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clippy: fix "this let-binding has unit value" warnings #25429

Merged
merged 1 commit into from
May 22, 2022

Conversation

brooksprumo
Copy link
Contributor

Problem

Clippy warns for let-bindings with unit values:

warning: this let-binding has unit value
   --> core/benches/banking_stage.rs:88:13
    |
88  | /             let _ignored = BankingStage::consume_buffered_packets(
89  | |                 &my_pubkey,
90  | |                 std::u128::MAX,
91  | |                 &poh_recorder,
...   |
100 | |                 10,
101 | |             );
    | |______________^
    |
    = note: `#[warn(clippy::let_unit_value)]` on by default
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
help: omit the `let` binding
    |
88  ~             BankingStage::consume_buffered_packets(
89  +                 &my_pubkey,
90  +                 std::u128::MAX,
91  +                 &poh_recorder,
92  +                 &mut transaction_buffer,
93  +                 None,
  ...

Summary of Changes

Remove the let bindings.

@brooksprumo brooksprumo marked this pull request as ready for review May 21, 2022 22:51
@brooksprumo brooksprumo merged commit f884203 into solana-labs:master May 22, 2022
@brooksprumo brooksprumo deleted the clippy/let_unit_value branch May 22, 2022 16:18
behzadnouri added a commit to behzadnouri/solana that referenced this pull request May 22, 2022
behzadnouri added a commit that referenced this pull request May 22, 2022
behzadnouri added a commit that referenced this pull request May 22, 2022
behzadnouri added a commit that referenced this pull request May 22, 2022
This partially reverts commit f884203.

Apparently CI runs for
#25429
#25429
have interleaved each other resulting in a broken master.
behzadnouri added a commit that referenced this pull request May 22, 2022
This partially reverts commit f884203.

Apparently CI runs for
#25380
#25429
have interleaved each other resulting in a broken master.
behzadnouri added a commit that referenced this pull request May 23, 2022
This partially reverts commit f884203.

Apparently CI runs for
#25380
#25429
have interleaved each other resulting in a broken master.
jeffwashington pushed a commit to jeffwashington/solana that referenced this pull request Jun 29, 2022
jeffwashington pushed a commit to jeffwashington/solana that referenced this pull request Jun 29, 2022
This partially reverts commit f884203.

Apparently CI runs for
solana-labs#25380
solana-labs#25429
have interleaved each other resulting in a broken master.
jeffwashington pushed a commit to jeffwashington/solana that referenced this pull request Jun 29, 2022
jeffwashington pushed a commit to jeffwashington/solana that referenced this pull request Jun 29, 2022
This partially reverts commit f884203.

Apparently CI runs for
solana-labs#25380
solana-labs#25429
have interleaved each other resulting in a broken master.
jeffwashington pushed a commit to jeffwashington/solana that referenced this pull request Jun 29, 2022
jeffwashington pushed a commit to jeffwashington/solana that referenced this pull request Jun 29, 2022
This partially reverts commit f884203.

Apparently CI runs for
solana-labs#25380
solana-labs#25429
have interleaved each other resulting in a broken master.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant