Reject durable nonce transactions not signed by authority #25831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstarry
added
v1.9
feature-gate
jstarry
force-pushed
the
feat/reject-unauthorized-nonce-txs
branch
2 times, most recently
from
14c46fb
to
eb33803
Compare
jackcmay
previously approved these changes
Jun 8, 2022
30 tasks
behzadnouri
reviewed
Jun 8, 2022
jstarry
force-pushed
the
feat/reject-unauthorized-nonce-txs
branch
from
791f825
to
95fcae6
Compare
behzadnouri
approved these changes
Jun 8, 2022
| @@ -21,13 +24,13 @@ pub fn create_account(lamports: u64) -> RefCell<AccountSharedData> { | |||
| } | |||
|
|
|||
| // TODO: Consider changing argument from Hash to DurableNonce. | |||
There was a problem hiding this comment.
this // TODO: ... was not a good idea. Since you are changing this area, maybe remove this as well.
| Ok(State::Initialized(ref data)) => hash == &data.blockhash(), | ||
| _ => false, | ||
| Ok(State::Initialized(data)) => (hash == &data.blockhash()).then(|| data), | ||
| _ => None, |
There was a problem hiding this comment.
Since you are changing this line, might be good to make this _ => ... more explicit, and avoid bugs in the future if State ever has a 3rd variant. Something like:
Ok(State::Initialized(data)) => ...
Ok(State::Uninitialized) => None,
Err(_) => None,
mergify bot
pushed a commit
that referenced
this pull request
Jun 8, 2022
(cherry picked from commit b2b426d) # Conflicts: # runtime/src/bank.rs # runtime/src/nonce_keyed_account.rs # sdk/program/src/message/sanitized.rs # sdk/src/feature_set.rs # send-transaction-service/src/send_transaction_service.rs
mergify bot
pushed a commit
that referenced
this pull request
Jun 8, 2022
(cherry picked from commit b2b426d) # Conflicts: # runtime/src/nonce_keyed_account.rs
mergify bot
added a commit
that referenced
this pull request
Jun 8, 2022
…25831) (#25849) * Reject durable nonce transactions not signed by authority (#25831) (cherry picked from commit b2b426d) # Conflicts: # runtime/src/bank.rs # runtime/src/nonce_keyed_account.rs # sdk/program/src/message/sanitized.rs # sdk/src/feature_set.rs # send-transaction-service/src/send_transaction_service.rs * resolve conflicts Co-authored-by: Justin Starry <justin@solana.com>
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 27, 2022
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 27, 2022
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 27, 2022
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 28, 2022
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 28, 2022
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 28, 2022
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 28, 2022
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 28, 2022
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 28, 2022
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 29, 2022
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 29, 2022
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
A transaction should only be processed as a durable nonce transaction if the used nonce account's authority signed the transaction.
Summary of Changes
Feature Gate Issue: #25835