avoid adding to 'uncleaned_roots' when generating index and caller pa… #25936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwashington
force-pushed
the
jun18
branch
2 times, most recently
from
e94ed81
to
027ba69
Compare
…sses accounts-db-skip-shrink
Codecov Report
@@ Coverage Diff @@
## master #25936 +/- ##
=========================================
- Coverage 82.1% 82.0% -0.2%
=========================================
Files 628 631 +3
Lines 171471 172929 +1458
=========================================
+ Hits 140878 141878 +1000
- Misses 30593 31051 +458 |
jeffwashington
added a commit
to jeffwashington/solana
that referenced
this pull request
Jul 6, 2022
…aller passes accounts-db-skip-shrink (solana-labs#25936)" This reverts commit e24cc53.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sses accounts-db-skip-shrink
Problem
See comment in change.
In high account count simulations, this causes validators to oom on the first clean in the bg.
The issue is also caused by the acct idx keeping items in-mem after they are scanned by clean. Clean can also be modified to not keep items in the acct idx if a scan determines they are not interesting to clean.
Summary of Changes
Don't add all roots to 'uncleaned_roots' at startup when --accounts-db-skip-shrink is passed.
Fixes #