Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement VoteInstruction::AuthorizeWithSeed & VoteInstruction::AuthorizeWithSeedChecked (backport #25928) #25956

Merged
merged 2 commits into from
Jun 14, 2022

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 14, 2022

This is an automatic backport of pull request #25928 done by Mergify.
Cherry-pick of 45d11f3 has failed:

On branch mergify/bp/v1.10/pr-25928
Your branch is up to date with 'origin/v1.10'.

You are currently cherry-picking commit 45d11f3d2.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   docs/src/cluster/stake-delegation-and-rewards.md
	modified:   programs/vote/src/vote_instruction.rs
	modified:   programs/vote/src/vote_state/mod.rs
	modified:   runtime/src/vote_parser.rs
	modified:   sdk/src/feature_set.rs
	modified:   transaction-status/src/parse_vote.rs

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   programs/vote/src/vote_processor.rs

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

…thorizeWithSeedChecked` (#25928)

* [vote_authorize_with_seed] Add `VoteInstruction::AuthorizeWithSeed`

* [vote_authorize_with_seed] You can now update a vote account's authority if it's a derived key for which you control the base key

* [vote_authorize_with_seed] Add test helper to create a vote account whose authorities are derived keys

* [vote_authorize_with_seed] Write tests to assert the behavior of `VoteInstruction::AuthorizeWithSeed`

* [vote_authorize_with_seed] Feature gate the `VoteInstruction::AuthorizeWithSeed` processor

* [vote_authorize_with_seed] Add `VoteInstruction::AuthorizeWithSeed` to transaction status parser

* [vote_authorize_with_seed] Add `VoteInstruction::AuthorizeWithSeed` to docs

* [vote_authorize_with_seed] Add `VoteInstruction::AuthorizeCheckedWithSeed`

* [vote_authorize_with_seed] You can now update a vote account's authority (while checking that the new authority has signed) if it's a derived
key for which you control the base key

* [vote_authorize_with_seed] Add `VoteInstruction::AuthorizeCheckedWithSeed` to transaction status parser

* [vote_authorize_with_seed] Write tests to assert the behavior of `VoteInstruction::AuthorizeCheckedWithSeed`

(cherry picked from commit 45d11f3)

# Conflicts:
#	programs/vote/src/vote_processor.rs
@mergify mergify bot added conflicts feature-gate Pull Request adds or modifies a runtime feature gate labels Jun 14, 2022
@mergify mergify bot added the automerge Merge this Pull Request automatically once CI passes label Jun 14, 2022
@mergify
Copy link
Contributor Author

mergify bot commented Jun 14, 2022

automerge label removed due to a CI failure

@mergify mergify bot removed the automerge Merge this Pull Request automatically once CI passes label Jun 14, 2022
@mergify mergify bot added automerge Merge this Pull Request automatically once CI passes and removed automerge Merge this Pull Request automatically once CI passes labels Jun 14, 2022
@mergify
Copy link
Contributor Author

mergify bot commented Jun 14, 2022

automerge label removed due to a CI failure

@mergify mergify bot added the automerge Merge this Pull Request automatically once CI passes label Jun 14, 2022
@mergify mergify bot merged commit bcffb4d into v1.10 Jun 14, 2022
@mergify mergify bot deleted the mergify/bp/v1.10/pr-25928 branch June 14, 2022 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this Pull Request automatically once CI passes conflicts feature-gate Pull Request adds or modifies a runtime feature gate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants