Add user-agent header to Solana rust client requests #26262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is meant to accompany #26236, so that RPC providers can measure if there's a drop in egress with the new version. |
mvines
previously approved these changes
Jun 27, 2022
steveluscher
added
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
RPC providers collect metrics today, but have no way of filtering those metrics by a particular version of the client. This would be useful in identifying regressions (eg. a version of the client that's particularly badly behaved) or improvements (eg. a version of the client that aims to reduce load on RPCs, like #26236).
Summary of Changes
user-agentHTTP header to each request.Test plan
Attached a proxy and observed the header making it out.