Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stats for readonly cache evicts and double the read-only account cache #26938

Merged
merged 3 commits into from Aug 15, 2022

Conversation

HaoranYi
Copy link
Contributor

@HaoranYi HaoranYi commented Aug 5, 2022

Problem

We are seeing rewards regression on 8/2/ epoch.
#26922

It seems that the cache is full during the epoch boundary.

Summary of Changes

Adding a stat for evict to verify the cache pressure during epoch boundary.

Fixes #

@HaoranYi HaoranYi requested review from jeffwashington and removed request for jeffwashington August 5, 2022 16:12
@stale
Copy link

stale bot commented Aug 13, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added stale [bot only] Added to stale content; results in auto-close after a week. and removed stale [bot only] Added to stale content; results in auto-close after a week. labels Aug 13, 2022
@jeffwashington jeffwashington self-requested a review August 15, 2022 16:05
jeffwashington
jeffwashington previously approved these changes Aug 15, 2022
Copy link
Contributor

@jeffwashington jeffwashington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mergify mergify bot dismissed jeffwashington’s stale review August 15, 2022 18:02

Pull request has been modified.

@HaoranYi HaoranYi self-assigned this Aug 15, 2022
@HaoranYi HaoranYi added v1.10 automerge Merge this Pull Request automatically once CI passes labels Aug 15, 2022
@mergify mergify bot removed the automerge Merge this Pull Request automatically once CI passes label Aug 15, 2022
@mergify
Copy link
Contributor

mergify bot commented Aug 15, 2022

automerge label removed due to a CI failure

@HaoranYi HaoranYi merged commit 1a90cff into solana-labs:master Aug 15, 2022
mergify bot pushed a commit that referenced this pull request Aug 15, 2022
* add stats for readonly cache evicts

* bump up account cache to 400M

* aggregate num_evicts in the loop

(cherry picked from commit 1a90cff)
mergify bot pushed a commit that referenced this pull request Aug 15, 2022
* add stats for readonly cache evicts

* bump up account cache to 400M

* aggregate num_evicts in the loop

(cherry picked from commit 1a90cff)
HaoranYi added a commit that referenced this pull request Aug 16, 2022
* add stats for readonly cache evicts

* bump up account cache to 400M

* aggregate num_evicts in the loop

(cherry picked from commit 1a90cff)
@HaoranYi HaoranYi changed the title Add stats for readonly cache evicts Add stats for readonly cache evicts and double the read-only account cache Aug 16, 2022
mergify bot added a commit that referenced this pull request Aug 16, 2022
* Add stats for readonly cache evicts (#26938)

* add stats for readonly cache evicts

* bump up account cache to 400M

* aggregate num_evicts in the loop

(cherry picked from commit 1a90cff)

* Mergify/bp/v1.10/pr 26938 (#27164)

* update rocks for cargo audit vunerability

* add cargo lock

* Revert "Mergify/bp/v1.10/pr 26938 (#27164)"

This reverts commit abd4c93.

* turn off cargo audit for rocksdb

Co-authored-by: HaoranYi <haoran.yi@gmail.com>
brooksprumo pushed a commit that referenced this pull request Aug 16, 2022
* add stats for readonly cache evicts

* bump up account cache to 400M

* aggregate num_evicts in the loop

(cherry picked from commit 1a90cff)
mergify bot added a commit that referenced this pull request Aug 16, 2022
Add stats for readonly cache evicts (#26938)

* add stats for readonly cache evicts

* bump up account cache to 400M

* aggregate num_evicts in the loop

(cherry picked from commit 1a90cff)

Co-authored-by: HaoranYi <haoran.yi@gmail.com>
xiangzhu70 pushed a commit to xiangzhu70/solana that referenced this pull request Aug 17, 2022
* add stats for readonly cache evicts

* bump up account cache to 400M

* aggregate num_evicts in the loop
@t-nelson
Copy link
Contributor

t-nelson commented Mar 25, 2024

were cluster metrics checked before merging this to ensure those potatoes that insist on running 128GB RAM have headroom?

n/m this is an historic change. i thought it was related to the recent proposal to bump again 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants