Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpc-sts: respect app exit in tx receiver thread #27404

Merged
merged 1 commit into from
Aug 26, 2022
Merged

rpc-sts: respect app exit in tx receiver thread #27404

merged 1 commit into from
Aug 26, 2022

Conversation

t-nelson
Copy link
Contributor

@t-nelson t-nelson commented Aug 25, 2022 •
edited

Problem

RPC STS ignores app exit, zombieing the process in some fatal error cases

Summary of Changes

check exit signal in tx receiver thread loop

CriesofCarrots
CriesofCarrots approved these changes Aug 25, 2022
View reviewed changes
Copy link
Contributor

@CriesofCarrots CriesofCarrots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that the other loop in this service is already doing this

lijunwangs
lijunwangs approved these changes Aug 25, 2022
View reviewed changes
Copy link
Contributor

@lijunwangs lijunwangs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@t-nelson t-nelson merged commit 14c60ba into solana-labs:master Aug 26, 2022
@t-nelson t-nelson deleted the rse branch August 26, 2022 16:53
This was referenced Aug 26, 2022
Merged
Merged
mergify bot added a commit that referenced this pull request Aug 26, 2022
@mergify @t-nelson
rpc-sts: respect app exit in tx receiver thread (backport #27404) (#2…
1333d0e 
…7423)

rpc-sts: respect app exit in tx receiver thread

(cherry picked from commit 14c60ba)

Co-authored-by: Trent Nelson <trent@solana.com>
mergify bot added a commit that referenced this pull request Aug 27, 2022
@mergify @t-nelson
rpc-sts: respect app exit in tx receiver thread (backport #27404) (#2…
dac50a6 
…7422)

rpc-sts: respect app exit in tx receiver thread

(cherry picked from commit 14c60ba)

Co-authored-by: Trent Nelson <trent@solana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CriesofCarrots CriesofCarrots CriesofCarrots approved these changes

@lijunwangs lijunwangs lijunwangs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@t-nelson @CriesofCarrots @lijunwangs