Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a flaky test #27572

Merged
merged 1 commit into from Sep 2, 2022
Merged

fix a flaky test #27572

merged 1 commit into from Sep 2, 2022

Conversation

tao-stones
Copy link
Contributor

@tao-stones tao-stones commented Sep 2, 2022

Problem

async update() in test could panic

Summary of Changes

  • call sync_update() instead in test

Fixes #

@tao-stones tao-stones marked this pull request as ready for review September 2, 2022 14:31
@tao-stones tao-stones added the automerge Merge this Pull Request automatically once CI passes label Sep 2, 2022
@mergify mergify bot merged commit c0f41fe into solana-labs:master Sep 2, 2022
@tao-stones tao-stones deleted the flacky-tests branch September 2, 2022 15:33
@tao-stones tao-stones changed the title fix a flacky test fix a flaky test Sep 2, 2022
CriesofCarrots pushed a commit that referenced this pull request Jan 6, 2023
CriesofCarrots added a commit that referenced this pull request Jan 7, 2023
… (backport #26709) (#29539)

* collect min prioritization fees when replaying sanitized transactions (#26709)

* Collect blocks' minimum prioritization fees when replaying sanitized transactions

* Limits block min-fee metrics reporting to top 10 writable accounts

* Add service thread to asynchronously update and finalize prioritization fee cache

* Add bench test for prioritization_fee_cache

Co-authored-by: Tyera Eulberg <teulberg@gmail.com>
(cherry picked from commit 8bb039d)

# Conflicts:
#	core/src/immutable_deserialized_packet.rs
#	core/src/replay_stage.rs
#	core/src/tvu.rs
#	core/src/unprocessed_packet_batches.rs
#	core/src/validator.rs

* Fix conflicts

* Don't use api from the future

* fix a flacky test (#27572)

Co-authored-by: Tao Zhu <82401714+taozhu-chicago@users.noreply.github.com>
Co-authored-by: Tyera Eulberg <tyera@solana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant