Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add new leader slot metric to track account contention throttling #27654

Merged
merged 1 commit into from
Sep 8, 2022
Merged

add new leader slot metric to track account contention throttling #27654

merged 1 commit into from
Sep 8, 2022

Conversation

mschneider
Copy link
Contributor

Problem

it's unclear how much impact attempts to write lock the same account from parallel banking threads on cluster speed has

Summary of Changes

added a metric to trace this in production

@mergify mergify bot added the community Community contribution label Sep 7, 2022
@mergify mergify bot requested a review from a team September 7, 2022 22:32
@mschneider
Copy link
Contributor Author

@taozhu-chicago this should help in understanding how contentious account locks are in production

@mschneider mschneider mentioned this pull request Sep 7, 2022
Closed
tao-stones
tao-stones approved these changes Sep 8, 2022
View reviewed changes
Copy link
Contributor

@tao-stones tao-stones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

core/src/leader_slot_banking_stage_metrics.rs
@@ -104,6 +104,11 @@ struct LeaderSlotPacketCountMetrics {
// then hit the age limit after failing to be comitted.
executed_transactions_failed_commit_count: u64,

// total number of transactions that were excluded from the block because there were concurrent write locks active.
// These transactions are added back to the buffered queue and are already counted in
// `self.retrayble_errored_transaction_count`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for clarifying this counter is a subset of retrayble_errored_transaction_count

@tao-stones tao-stones merged commit cc58968 into solana-labs:master Sep 8, 2022
@mergify mergify bot mentioned this pull request Sep 8, 2022
Merged
mergify bot pushed a commit that referenced this pull request Sep 8, 2022
@mschneider @mergify
add new leader slot metric to track account contention throttling (#2…
5869fd7 
…7654)

(cherry picked from commit cc58968)
@mergify mergify bot mentioned this pull request Sep 8, 2022
Merged
mergify bot pushed a commit that referenced this pull request Sep 8, 2022
@mschneider @mergify
add new leader slot metric to track account contention throttling (#2…
dd1e9ff 
…7654)

(cherry picked from commit cc58968)
mergify bot added a commit that referenced this pull request Sep 8, 2022
@mergify @mschneider
add new leader slot metric to track account contention throttling (ba…
98577ac 
…ckport #27654) (#27668)

add new leader slot metric to track account contention throttling (#27654)

(cherry picked from commit cc58968)

Co-authored-by: Maximilian Schneider <mail@maximilianschneider.net>
mergify bot added a commit that referenced this pull request Sep 9, 2022
@mergify @mschneider
add new leader slot metric to track account contention throttling (ba…
f187a2e 
…ckport #27654) (#27667)

add new leader slot metric to track account contention throttling (#27654)

(cherry picked from commit cc58968)

Co-authored-by: Maximilian Schneider <mail@maximilianschneider.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tao-stones tao-stones tao-stones approved these changes

Assignees
No one assigned
Labels
community Community contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mschneider @tao-stones @jstarry