stats for staked/unstaked repair requests #28215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behzadnouri
reviewed
Oct 4, 2022
| if budget_exhausted { | ||
| stats.dropped_requests_outbound_bandwidth += 1; | ||
| continue; | ||
| } |
There was a problem hiding this comment.
The issue I see here is that this is still paying for deserializing packets and looking up pubkeys in epoch_staked_nodes hashmap even though the outbound budget is exhausted. This seems to me pretty wasteful just for the sake of collecting metrics.
The other thing, as previously mentioned: #27771 (comment)
I still don't see why stake vs unstaked breakdown of load matters?
If we cannot handle staked nodes requests, then why should we allocate any budget to unstaked nodes?
There was a problem hiding this comment.
and, if we want to prioritize requests by stake, then again, we don't care about stake vs unstaked breakdown
mergify
bot
dismissed
behzadnouri’s stale review
Pull request has been modified.
mergify bot
pushed a commit
that referenced
this pull request
Oct 5, 2022
(cherry picked from commit e3e888c)
jbiseda
added a commit
to jbiseda/solana
that referenced
this pull request
Oct 10, 2022
solana-labs#28230) stats for staked/unstaked repair requests (solana-labs#28215) (cherry picked from commit e3e888c) Co-authored-by: Jeff Biseda <jbiseda@gmail.com>
mergify bot
pushed a commit
that referenced
this pull request
Oct 26, 2022
(cherry picked from commit e3e888c) # Conflicts: # core/src/serve_repair.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
need stats to break down repair requests by staked/unstaked senders
Summary of Changes
minimal changes to track staked/unstaked sender of all requests which pass the load shedding filter.
See also #27708 #27771
Fixes #