-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support VersionedMessage
in getFeeForMessage
#28996
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #28996 +/- ##
=========================================
- Coverage 77.1% 76.4% -0.8%
=========================================
Files 55 55
Lines 2934 3084 +150
Branches 408 454 +46
=========================================
+ Hits 2264 2358 +94
- Misses 529 568 +39
- Partials 141 158 +17 |
steveluscher
approved these changes
Nov 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gnapoli23
pushed a commit
to gnapoli23/solana
that referenced
this pull request
Dec 16, 2022
This was referenced Dec 23, 2022
This was referenced Dec 28, 2022
nickfrosty
pushed a commit
to nickfrosty/solana
that referenced
this pull request
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As noticed in https://solana.stackexchange.com/questions/4597/how-getfeeformessage-for-versioned-transaction, we can't use
getFeeForMessage
with a versioned message.Summary of Changes
Similar to how versioned and legacy transactions are supported in
sendTransaction
, acceptVersionedMessage
ingetFeeForMessage
, and serialize it properly.There's some mismatch in how the types are defined between
VersionedTransaction
andVersionedMessage
, so here's the type definition for reference:Fixes #