moves turbine-disabled check to shred-fetch-stage #30799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If turbine_disabled is true, the commit discards turbine packets earlier in the pipeline so that they won't interfere with the deduper and the packets can get through once turbine is enabled again. This is a prerequisite of: solana-labs#30786 so that local-cluster tests pass.
behzadnouri
force-pushed
the
mv-turbine-disabled
branch
from
af16cd5
to
8cdc5bc
Compare
t-nelson
approved these changes
Mar 20, 2023
Codecov Report
@@ Coverage Diff @@
## master #30799 +/- ##
=======================================
Coverage 81.3% 81.3%
=======================================
Files 726 726
Lines 203490 203494 +4
=======================================
+ Hits 165599 165620 +21
+ Misses 37891 37874 -17 |
mergify bot
pushed a commit
that referenced
this pull request
Mar 21, 2023
If turbine_disabled is true, the commit discards turbine packets earlier in the pipeline so that they won't interfere with the deduper and the packets can get through once turbine is enabled again. This is a prerequisite of: #30786 so that local-cluster tests pass. (cherry picked from commit e66edeb) # Conflicts: # core/src/shred_fetch_stage.rs
mergify bot
added a commit
that referenced
this pull request
Mar 21, 2023
…30799) (#30828) * moves turbine-disabled check to shred-fetch-stage (#30799) If turbine_disabled is true, the commit discards turbine packets earlier in the pipeline so that they won't interfere with the deduper and the packets can get through once turbine is enabled again. This is a prerequisite of: #30786 so that local-cluster tests pass. (cherry picked from commit e66edeb) # Conflicts: # core/src/shred_fetch_stage.rs * resolves mergify merge conflicts --------- Co-authored-by: behzad nouri <behzadnouri@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Local cluster tests fail in #30786 because when
turbine_disabledis true packets are still recorded in the deduper even though they are dropped and whenturbine_disabledis set back to false, new packets are discarded as duplicate.Summary of Changes
If
turbine_disabledis true the commit discards turbine packets earlier in the pipeline so that they won't interfere with the deduper and the packets can get through once turbine is enabled again.This is a prerequisite of #30786 so that local-cluster tests pass.