Make BanksClient timeout after 10 seconds instead of 60 #30904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #30904 +/- ##
=======================================
Coverage 81.5% 81.5%
=======================================
Files 727 727
Lines 205166 205187 +21
=======================================
+ Hits 167295 167336 +41
+ Misses 37871 37851 -20 |
CriesofCarrots
previously approved these changes
Mar 28, 2023
|
Oops, might have prematurely approved. Lgtm pending CI success. |
CriesofCarrots
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
BanksClient times out in certain situations, such as when you try to send a transaction but it doesn't get committed (#30527). This should be fixed but in the meantime it would be better not to wait a whole minute before timing out.
Summary of Changes
Removed lines that increment the deadline by 50 seconds, with the result that the deadline is now 10 seconds instead of 60. Those lines were written by @garious in #10728. Unfortunately I can't tell why they are there, maybe @garious remembers why.
Also added a test to demonstrate a panic on timeout.