removes Packet Meta.sender_stake and find_packet_sender_stake_stage #31077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Packet Meta.sender_stake is unused since solana-labs#26512 removed sender_stake from banking-stage buffer prioritization.
Codecov Report
@@ Coverage Diff @@
## master #31077 +/- ##
========================================
Coverage 81.4% 81.4%
========================================
Files 728 727 -1
Lines 206004 205880 -124
========================================
- Hits 167830 167761 -69
+ Misses 38174 38119 -55 |
tao-stones
approved these changes
Apr 6, 2023
There was a problem hiding this comment.
lgtm with a nit. banking_stage no longer uses packet.sender_stake, thanks for removing dead code.
A quick note: the packets threshold MAX_FINDPACKETSENDERSTAKE_BATCH removed by deleting find_packet_sender_stake_stage.rs has duplicated implementation in sigverify_stage, so removing it should not have impact.
| let sender_stake = distribution.sample(&mut rng); | ||
| packet.meta_mut().sender_stake = sender_stake as u64; | ||
| packet | ||
| Packet::from_data(None, tx).unwrap() |
There was a problem hiding this comment.
nit: after removed code to set random sender_stake, this function became same as build_packet_batch(). Can remove build_randomized_packet_batch() and related bench test all together. This can be done in follow up PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Packet Meta.sender_stake is unused since #26512
removed sender_stake from banking-stage buffer prioritization.
Summary of Changes
removed Packet Meta.sender_stake and find_packet_sender_stake_stage