-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove sender stakes from banking_stage buffer prioritization #26512
Remove sender stakes from banking_stage buffer prioritization #26512
Conversation
Agreed. You can see evidence that the few senders using fee priority are already using highly nuanced fees. There is incentive not to have the same priority as others and minutely tweak things... thus there will likely be a great variety of fee priorities observed. Pays 0.000006001 Sol Pays 0.000005002 In summary, I don't think sorting by stake weight will accomplish much other than causing worry about stake centralization issues (i.e. the powerful get richer -- which I've seen people wonder already) and adding a fud angle. |
* remove sender stakes from banking_stage buffer prioritization (cherry picked from commit a3b0943)
solana-labs#26512 removed sender_stake from banking-stage buffer prioritization and it is not used any more.
solana-labs#26512 removed sender_stake from banking-stage buffer prioritization and it is not used any more.
Packet Meta.sender_stake is unused since solana-labs#26512 removed sender_stake from banking-stage buffer prioritization.
Packet Meta.sender_stake is unused since solana-labs#26512 removed sender_stake from banking-stage buffer prioritization.
Problem
It seems unnecessary to prioritize packets by sender stake on top of transaction's compute-unit price, due to:
therefore it makes sense to remove sender stake from MinMaxHeap ordering to save some computing and simplify code a bit.
Summary of Changes
Remove sender-stake from MinMaxHeap ordering.
Fixes #