Refactor - Use builtin function interface from rbpf #31221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lichtso
force-pushed
the
refactor/use_builtin_function_interface_from_rbpf
branch
21 times, most recently
from
568e3ec
to
e6f8bc6
Compare
Lichtso
force-pushed
the
refactor/use_builtin_function_interface_from_rbpf
branch
from
e6f8bc6
to
a9dbada
Compare
Lichtso
force-pushed
the
refactor/use_builtin_function_interface_from_rbpf
branch
from
a9dbada
to
b98e400
Compare
Codecov Report
@@ Coverage Diff @@
## master #31221 +/- ##
=======================================
Coverage 81.5% 81.5%
=======================================
Files 731 732 +1
Lines 206979 206977 -2
=======================================
+ Hits 168757 168780 +23
+ Misses 38222 38197 -25 |
alessandrod
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Built-ins (
ProcessInstructionWithContext) and syscalls (BuiltInFunction) use two different function interfaces.Summary of Changes
In order to unify them this PR replaces the interface of built-in by the one used for RBPF syscalls.
This does not allow access of built-ins as syscalls yet, it is merely a preparation step.