Refactor - Moves the system program into its own crate #31244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lichtso
force-pushed
the
refactor/move_system_program_into_its_own_crate
branch
4 times, most recently
from
4aceea0
to
99c9b5a
Compare
Lichtso
force-pushed
the
refactor/move_system_program_into_its_own_crate
branch
from
99c9b5a
to
71c88fe
Compare
pgarg66
approved these changes
Apr 18, 2023
Codecov Report
@@ Coverage Diff @@
## master #31244 +/- ##
=======================================
Coverage 81.5% 81.5%
=======================================
Files 729 730 +1
Lines 206621 206617 -4
=======================================
+ Hits 168484 168523 +39
+ Misses 38137 38094 -43 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently the system program is the only built-in which lives in the runtime crate and not in the programs directory like all other programs do. This causes problems with cyclic dependencies which have to be removed for #31221.
Summary of Changes
Moves the system program into its own crate in "programs/system"