Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: stop windows building on master temporarily #31353

Merged
merged 1 commit into from
Apr 26, 2023
Merged

ci: stop windows building on master temporarily #31353

merged 1 commit into from
Apr 26, 2023

Conversation

yihau
Copy link
Member

@yihau yihau commented Apr 26, 2023

Problem

https://discord.com/channels/428295358100013066/560503042458517505/1100438277711986730

we need to upgrade our tokio crates to make it green

Summary of Changes

stop windows building on master temporarily

@yihau yihau added the automerge Merge this Pull Request automatically once CI passes label Apr 26, 2023
ryoqun
ryoqun approved these changes Apr 26, 2023
View reviewed changes
Copy link
Member

@ryoqun ryoqun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (hey, jumping on here out of nowhere; i deadly want a green master to rebase on)

@mergify mergify bot merged commit 2dcdfff into solana-labs:master Apr 26, 2023
4 checks passed
@ryoqun
Copy link
Member

ryoqun commented Apr 26, 2023

also, i requested ntapi for our tiny favor: MSxDOS/ntapi#12 (comment)

@yihau yihau deleted the stop-windows-build-on-master branch April 26, 2023 04:49
@yihau
Copy link
Member Author

yihau commented Apr 26, 2023

yeah! thank you and hope it can happen! 🤞

@ilya-bobyr
Copy link
Contributor

I've merged an upgrade for console from 0.15.0 to 0.15.5: #31435
My previous attempt failed, because solana_install was not declaring all the dependencies correctly.
console switching to another crate broke solana_install.
solana_install dependencies have been fixed, but in order to be sure, I need a Windows build to run.

Leaving a note here, in case re-enabling Windows builds on master triggers a failure in solana_install again.

Or is there a way to run a Windows build on Linux?
I've quickly tried this:

rustup target add x86_64-pc-windows-gnu
cargo build --target x86_64-pc-windows-gnu --package solana_install

As suggested here: https://stackoverflow.com/a/62853319/1989046
But it did not work for me.

@yihau
Copy link
Member Author

yihau commented May 2, 2023

I tried to build it here https://github.com/yihau/solana/actions/runs/4860100489/jobs/8663527356#step:3:6
I think it can build successfully on Windows with rust 1.68.2.

@ilya-bobyr
Copy link
Contributor

I tried to build it here yihau/solana/actions/runs/4860100489/jobs/8663527356#step:3:6 I think it can build successfully on Windows with rust 1.68.2.

Awesome. Thanks a lot!

@yihau yihau mentioned this pull request May 31, 2023
Merged
ryoqun added a commit to ryoqun/solana that referenced this pull request Jun 5, 2023
@ryoqun
Revert "ci: stop windows building on master temporarily (solana-labs#…
e7a132b 
…31353)"

This reverts commit 2dcdfff.
ryoqun added a commit to ryoqun/solana that referenced this pull request Jun 5, 2023
@ryoqun
Revert "ci: stop windows building on master temporarily (solana-labs#…
be54d14 
…31353)"

This reverts commit 2dcdfff.
@ryoqun ryoqun mentioned this pull request Jun 5, 2023
Merged
ryoqun added a commit that referenced this pull request Jun 5, 2023
@ryoqun
Patch ntapi to restore windows build (#31961)
39770b2 
* Patch ntapi to restore windows build

* Update Cargo.lock...

* Add comment for justification of this patching

MSxDOS/ntapi#11
MSxDOS/ntapi#12

* Revert "ci: stop windows building on master temporarily (#31353)"

This reverts commit 2dcdfff.

* Use solana-labs fork

* Ugh..
ryoqun added a commit to ryoqun/solana that referenced this pull request Jun 6, 2023
@ryoqun
Patch ntapi to restore windows build (solana-labs#31961)
4a38aeb 
* Patch ntapi to restore windows build

* Update Cargo.lock...

* Add comment for justification of this patching

MSxDOS/ntapi#11
MSxDOS/ntapi#12

* Revert "ci: stop windows building on master temporarily (solana-labs#31353)"

This reverts commit 2dcdfff.

* Use solana-labs fork

* Ugh..
ryoqun added a commit that referenced this pull request Jun 6, 2023
@ryoqun
Patch ntapi for v1.16.x to provide windows binaries (#31982)
ca2881a 
* Shift crossbeam comment for upcoming 2nd patch... (#31963)

* Patch ntapi to restore windows build (#31961)

* Patch ntapi to restore windows build

* Update Cargo.lock...

* Add comment for justification of this patching

MSxDOS/ntapi#11
MSxDOS/ntapi#12

* Revert "ci: stop windows building on master temporarily (#31353)"

This reverts commit 2dcdfff.

* Use solana-labs fork

* Ugh..

* Patch ntapi more thoroughly (#31970)

* Patch spl-token-cli build as well...

* Patch sbf/Cargo.toml for consistency

* Remove --locked for cli-arg based patch... (#31971)

* Bump patched ntapi from v0.3.6 to v0.3.7 (#31981)

* Revert "ci: stop windows build (#31893)"

This reverts commit 30f9e43.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryoqun ryoqun ryoqun approved these changes

@CriesofCarrots CriesofCarrots Awaiting requested review from CriesofCarrots

Assignees
No one assigned
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yihau @ryoqun @ilya-bobyr