Patch ntapi for v1.16.x to provide windows binaries #31982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Patch ntapi to restore windows build * Update Cargo.lock... * Add comment for justification of this patching MSxDOS/ntapi#11 MSxDOS/ntapi#12 * Revert "ci: stop windows building on master temporarily (solana-labs#31353)" This reverts commit 2dcdfff. * Use solana-labs fork * Ugh..
* Patch spl-token-cli build as well... * Patch sbf/Cargo.toml for consistency
ryoqun
changed the title
ryoqun
changed the title
Codecov Report
@@ Coverage Diff @@
## v1.16 #31982 +/- ##
=======================================
Coverage 81.8% 81.9%
=======================================
Files 759 759
Lines 207357 207357
=======================================
+ Hits 169781 169872 +91
+ Misses 37576 37485 -91 |
ryoqun
changed the title
ryoqun
commented
Jun 6, 2023
| - v[0-9]+.[0-9]+ | ||
| - '!v1.16' |
yihau
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is cumulative collection of prs to re-enable Windows binaries for v1.16 (see commits list for details)
@yihau i'm not that sure about the precise release process these days. after this pr lands onto the v1.16 branch, v1.16.1 release page will automatically got attached with windows binaries? cc: @willhickey