Feature Gate Update - Requires the owner accounts of programs to be built-ins. #31488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(owned by the native_loader and have the executable flag set)
Lichtso
changed the title
Lichtso
added a commit
to Lichtso/solana
that referenced
this pull request
May 4, 2023
pgarg66
approved these changes
May 4, 2023
Codecov Report
@@ Coverage Diff @@
## master #31488 +/- ##
=========================================
- Coverage 81.4% 81.4% -0.1%
=========================================
Files 731 731
Lines 208718 208723 +5
=========================================
- Hits 170017 169977 -40
- Misses 38701 38746 +45 |
Lichtso
added a commit
that referenced
this pull request
May 5, 2023
* Adds feature disable_builtin_loader_ownership_chains. * Removes test_load_accounts_max_call_depth(). * Factors account indices out of match. * Turns "match" into "if let Some(...) = ...". * Renames program_owner => owner_id. * Adds the actual feature gate to load_executable_accounts(). * Backport of #31488.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The feature
disable_builtin_loader_ownership_chainsis designed to strictly limit the length down to two. However, it does not check that the owner of the program is owned itself by thenative_loaderand has the executable flag set like the chain loader did before.Summary of Changes
disable_builtin_loader_ownership_chains.native_loaderchanges its error message fromCallChainTooDeeptoInvalidProgramForExecution.Feature Gate Issue: #29956