Retain runtime environment config for unloaded programs #31953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #31953 +/- ##
=========================================
- Coverage 81.9% 81.9% -0.1%
=========================================
Files 760 760
Lines 207382 207392 +10
=========================================
- Hits 169904 169901 -3
- Misses 37478 37491 +13 |
Lichtso
reviewed
Jun 2, 2023
Lichtso
approved these changes
Jun 3, 2023
mergify bot
pushed a commit
that referenced
this pull request
Jun 3, 2023
* Retain runtime environment config for unloaded programs (cherry picked from commit 1b30de4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This is a preparation for #31945.
When a program is unloaded, it's loader configuration is dropped. The configuration is useful to check if program needs re-verification when it is reloaded. If the configuration (e.g. feature set) has been modified, the program must be re-verified.
Summary of Changes
Retain the configuration as part of
Unloadedvariant.Fixes #