Decouple program-v4 command processors from CliConfig #33554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #33554 +/- ##
=======================================
Coverage 81.7% 81.7%
=======================================
Files 805 805
Lines 218162 218177 +15
=======================================
+ Hits 178410 178437 +27
+ Misses 39752 39740 -12 |
Lichtso
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The program-v4 command processors depend on
CliConfig. This is making it hard to reuse the code in cargo-registry server.Summary of Changes
Decouple the code from
CliConfigby introducingProgramV4CommandConfig.Fixes #