validator: skip health check #33568
Merged
validator: skip health check #33568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #33568 +/- ##
=========================================
- Coverage 81.7% 81.7% -0.1%
=========================================
Files 807 807
Lines 218283 218287 +4
=========================================
- Hits 178485 178467 -18
- Misses 39798 39820 +22 |
mvines
reviewed
Oct 6, 2023
diman-io
force-pushed
the
diman/pr/skip-health-check
branch
from
b7faa48
to
36045c5
Compare
|
Hi @mvines, no chance for |
|
v1.17 seems fine to me, it's not really a critical bug fix so i don't feel like a v1.16 backport is appropriate, even though I appreciate this is a low risk change |
mergify bot
pushed a commit
that referenced
this pull request
Oct 9, 2023
* validator: skip health check * keep `healthy` as a boolean (cherry picked from commit 7afb11f)
mvines
pushed a commit
that referenced
this pull request
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Issues with
getHealthare known: #16957 And I believe that the issue will be fundamentally resolved.But right now, I'm concerned about updating the validator using
wait-for-restart-windowandexit.There are already a lot of messages in the chats for 1.16.
I propose this tiny change that would allow bypassing the health check.
I sincerely hope for
v1.16andv1.17Summary of Changes
Added the
--skip-health-checkflag for thewait-for-restart-windowandexitcommandsFixes #33553