Initialize fork graph in program cache during bank_forks creation #33810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgarg66
force-pushed
the
set-fork-graph
branch
2 times, most recently
from
27567f9
to
e3804b5
Compare
pgarg66
force-pushed
the
set-fork-graph
branch
from
e3804b5
to
1654029
Compare
pgarg66
force-pushed
the
set-fork-graph
branch
2 times, most recently
from
502d5c7
to
033e78e
Compare
pgarg66
force-pushed
the
set-fork-graph
branch
from
033e78e
to
0482615
Compare
|
The need for this change was identified due to failing tests in #33806 |
Codecov Report
@@ Coverage Diff @@
## master #33810 +/- ##
=========================================
- Coverage 81.8% 81.8% -0.1%
=========================================
Files 807 807
Lines 217406 217428 +22
=========================================
+ Hits 178043 178047 +4
- Misses 39363 39381 +18 |
Lichtso
reviewed
Oct 23, 2023
Lichtso
approved these changes
Oct 23, 2023
mergify bot
pushed a commit
that referenced
this pull request
Oct 23, 2023
…33810) * Initialize fork graph in program cache during bank_forks creation * rename BankForks::new to BankForks::new_rw_arc * fix compilation * no need to set fork_graph on insert() * fix partition tests (cherry picked from commit 9d42cd7) # Conflicts: # core/src/repair/repair_service.rs # core/tests/epoch_accounts_hash.rs # ledger/src/blockstore_processor.rs # rpc/src/rpc_service.rs # runtime/src/bank/tests.rs
mergify bot
added a commit
that referenced
this pull request
Oct 23, 2023
…ion (backport of #33810) (#33817) * Initialize fork graph in program cache during bank_forks creation (#33810) * Initialize fork graph in program cache during bank_forks creation * rename BankForks::new to BankForks::new_rw_arc * fix compilation * no need to set fork_graph on insert() * fix partition tests (cherry picked from commit 9d42cd7) # Conflicts: # core/src/repair/repair_service.rs # core/tests/epoch_accounts_hash.rs # ledger/src/blockstore_processor.rs # rpc/src/rpc_service.rs # runtime/src/bank/tests.rs * fix merge conflicts --------- Co-authored-by: Pankaj Garg <pankaj@solana.com>
anwayde
pushed a commit
to firedancer-io/solana
that referenced
this pull request
Nov 16, 2023
…ion (backport of solana-labs#33810) (solana-labs#33817) * Initialize fork graph in program cache during bank_forks creation (solana-labs#33810) * Initialize fork graph in program cache during bank_forks creation * rename BankForks::new to BankForks::new_rw_arc * fix compilation * no need to set fork_graph on insert() * fix partition tests (cherry picked from commit 9d42cd7) # Conflicts: # core/src/repair/repair_service.rs # core/tests/epoch_accounts_hash.rs # ledger/src/blockstore_processor.rs # rpc/src/rpc_service.rs # runtime/src/bank/tests.rs * fix merge conflicts --------- Co-authored-by: Pankaj Garg <pankaj@solana.com>
anwayde
pushed a commit
to firedancer-io/solana
that referenced
this pull request
Nov 16, 2023
…ion (backport of solana-labs#33810) (solana-labs#33817) * Initialize fork graph in program cache during bank_forks creation (solana-labs#33810) * Initialize fork graph in program cache during bank_forks creation * rename BankForks::new to BankForks::new_rw_arc * fix compilation * no need to set fork_graph on insert() * fix partition tests (cherry picked from commit 9d42cd7) # Conflicts: # core/src/repair/repair_service.rs # core/tests/epoch_accounts_hash.rs # ledger/src/blockstore_processor.rs # rpc/src/rpc_service.rs # runtime/src/bank/tests.rs * fix merge conflicts --------- Co-authored-by: Pankaj Garg <pankaj@solana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The instance of
fork_graphinLoadedProgramscache is not initialized in all the tests.Summary of Changes
BankForksconstructorsArc<RwLock<>>Fixes #