-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase pull request ContactInfo
probability
#34231
Increase pull request ContactInfo
probability
#34231
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #34231 +/- ##
=======================================
Coverage 81.9% 81.9%
=======================================
Files 819 819
Lines 219350 219350
=======================================
+ Hits 179698 179726 +28
+ Misses 39652 39624 -28 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks for catching this.
I believe this needs to be backported to v1.17.
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
* ensure new contactinfo propagated quicker when handling pull requests * improve readability (cherry picked from commit 0a2ff85)
ContactInfo
probability
Problem
we upgraded to a new
ContactInfo
, but we haven't increased the newContactInfo
's propagation probability through pull requests as it is forLegacyContactInfo
Summary of Changes
Added in score increase for
ContactInfo
Fixes #