Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase pull request ContactInfo probability #34231

Conversation

gregcusack
Copy link
Contributor

Problem

we upgraded to a new ContactInfo, but we haven't increased the new ContactInfo's propagation probability through pull requests as it is for LegacyContactInfo

Summary of Changes

Added in score increase for ContactInfo

Fixes #

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Merging #34231 (65e02e4) into master (e832765) will increase coverage by 0.0%.
Report is 1 commits behind head on master.
The diff coverage is 100.0%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #34231   +/-   ##
=======================================
  Coverage    81.9%    81.9%           
=======================================
  Files         819      819           
  Lines      219350   219350           
=======================================
+ Hits       179698   179726   +28     
+ Misses      39652    39624   -28     

Copy link
Contributor

@behzadnouri behzadnouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for catching this.
I believe this needs to be backported to v1.17.

@behzadnouri behzadnouri added the v1.17 PRs that should be backported to v1.17 label Nov 29, 2023
Copy link
Contributor

mergify bot commented Nov 29, 2023

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

@gregcusack gregcusack merged commit 0a2ff85 into solana-labs:master Nov 29, 2023
33 checks passed
mergify bot pushed a commit that referenced this pull request Nov 29, 2023
* ensure new contactinfo propagated quicker when handling pull requests

* improve readability

(cherry picked from commit 0a2ff85)
@gregcusack gregcusack deleted the increase-pull-request-clusterinfo-probability branch November 29, 2023 18:44
gregcusack added a commit that referenced this pull request Nov 29, 2023
) (#34262)

Increase pull request clusterinfo probability (#34231)

* ensure new contactinfo propagated quicker when handling pull requests

* improve readability

(cherry picked from commit 0a2ff85)

Co-authored-by: Greg Cusack <greg.cusack@solana.com>
@gregcusack gregcusack changed the title Increase pull request clusterinfo probability Increase pull request ContactInfo probability Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v1.17 PRs that should be backported to v1.17
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants