Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Stabilize fn coverage by creating a clean room #7576
Coverage report is lying (partly). So, increasing coverage isn't fun. ;)
Summary of Changes
Casual quick inspection and my hunch says, this might fix the issue. :p I'll add the findings as a comment later. First, let the CI spin. :)
Found in the middle of #7546
@@ Coverage Diff @@ ## master #7576 +/- ## ======================================== + Coverage 71.8% 81.7% +9.8% ======================================== Files 244 244 Lines 56626 49807 -6819 ======================================== + Hits 40680 40706 +26 + Misses 15946 9101 -6845
After painful trials, I've found pruning doesn't work.
The somewhat-complete detailed investigation report is here. :)
The excerpt for the pinned-down culprit of our diverged coverage reports:
As shown above, the bad coverage report double-counts the total number of functions. This seems to happen for many files, not alone this.
This is caused by the existence of stale
My guess is that multiple stale
Simply removing them doesn't help as well. Removing would cause
So, drawing from these tearful and restraining findings, as the last resort, let's stash updated and relevant coverage data files into a newly-created empty dir...
(Sorry bad explanation; I'm getting tired... :p)