Remove support for stake redelegation #7995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rob-solana
force-pushed
the
Remove-support-for-stake-redelegation
branch
from
e94895a
to
ae408b8
Compare
Codecov Report
@@ Coverage Diff @@
## master #7995 +/- ##
========================================
- Coverage 82.1% 82.1% -0.1%
========================================
Files 244 245 +1
Lines 53044 53040 -4
========================================
- Hits 43565 43552 -13
- Misses 9479 9488 +9 |
rob-solana
force-pushed
the
Remove-support-for-stake-redelegation
branch
from
ae408b8
to
c173a92
Compare
mergify bot
pushed a commit
that referenced
this pull request
Jan 30, 2020
* Remove support for stake redelegation * fixup (cherry picked from commit e6803da) # Conflicts: # programs/stake/src/stake_state.rs
mvines
pushed a commit
that referenced
this pull request
Jan 30, 2020
* Remove support for stake redelegation * fixup
solana-grimes
pushed a commit
that referenced
this pull request
Jan 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
A staker can effectively defeat cooldown and screw up consensus by creating a dummy vote account and then redelegating to it.
Such a staker can't withdraw early, but bank weights are disrupted outside of warmup/cooldown.
Summary of Changes
Remove support for redelegate(), except after cool down
Fixes #7884
Fixes #7858