Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: constrain the connection interface of sendTransaction() to only that which is required #621

Closed
wants to merge 1 commit into from
Closed

feat: constrain the connection interface of sendTransaction() to only that which is required #621

wants to merge 1 commit into from

Conversation

steveluscher
Copy link
Contributor

Related to the soon-to-be-released anza-xyz/wallet-adapter#848.

preflightCommitment: getTargetCommitment(),
});
}
const serializedTransaction = signedTransaction.serialize();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both LegacyTransaction and VersionedTransaction implement serialize() so there's no reason to disambiguate.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, lgtm

@steveluscher steveluscher closed this by deleting the head repository Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants