Fix and improve PHAR generator #366
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Solarium_Autoloader` class is now `Solarium\Autoloader`. The `Solarium_Version` class does no longer exist and `Solarium\Client::VERSION` must be used instead.
`__halt_compiler` does not exist. This is `__HALT_COMPILER`.
Since Solarium has dependencies, this is more interesting to include vendors (aka dependencies) inside the PHAR file. Thus we include the `library/` directory with the `vendor/` directory.
Since the PHAR includes dependencies, we must use Composer's autoloader. It ensures all dependencies will be loaded correctly and as expected.
By forcing the root with a leading slash, it avoids Git to look up inside the whole tree of files.
|
Last commit failed due to a timeout on Travis. Please, could you restart the build? Everything is ok then. |
|
Thanks for your work, I've merged it in PR #369 |
|
You're welcome :-). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello :-),
A lot of different commits here:
.gitignorefile is updated (bd358d8 and 4b810f6).Now it works great :-].