Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to add multiple boostqueries to dismax parser #391

Merged
merged 4 commits into from
Feb 1, 2016
Merged

Conversation

chs2
Copy link
Contributor

@chs2 chs2 commented Jan 14, 2016

Inspired by #314

Work derived from query filter management

Methods setBoostQuery et getBoostQuery have been written to be as backward compatible as possible.

@chs2
Copy link
Contributor Author

chs2 commented Jan 14, 2016

I just saw that I forgot to update the eDisMax RequestBuilder.
Do you need a new pull request ?

@basdenooijer
Copy link
Member

If you commit and push your changes they should be added to this PR automatically and the CI checks will also be done again.

schausson added 3 commits January 14, 2016 15:36
@chs2
Copy link
Contributor Author

chs2 commented Jan 29, 2016

Hi,

Is there anything (tests, docs ...) missing for this request to be pulled ?

Thanks.

@basdenooijer
Copy link
Member

The PR looks ok, it's just that I've been busy. You could include an update to the docs in the PR but that's not mandatory.
I'll try to merge the PR later today.

basdenooijer added a commit that referenced this pull request Feb 1, 2016
Added option to add multiple boostqueries to dismax parser
@basdenooijer basdenooijer merged commit db31da7 into solariumphp:develop Feb 1, 2016
@basdenooijer
Copy link
Member

Nice work! It will be included in the next Solarium release

@marinpurgar
Copy link
Contributor

Kudos! 👍 Just what I needed ;)

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 94.609% when pulling 27e65b3 on chs2:develop into 0d366ee on solariumphp:develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants