Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Psr18Adapter not final and private members/methods protected #796

Closed

Conversation

thomascorthals
Copy link
Member

I've turned Psr18Adapter into a non-final class and made all private members and methods protected instead. This is in line with the customisation philosophy described in the docs.

3. and also still supporting the extending of classes (Solarium doesn't use 'private' or 'final' anywhere)

This closes #795.

@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2020

Codecov Report

Merging #796 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #796   +/-   ##
=========================================
  Coverage     90.61%   90.61%           
  Complexity     3530     3530           
=========================================
  Files           304      304           
  Lines          7627     7627           
=========================================
  Hits           6911     6911           
  Misses          716      716           
Flag Coverage Δ Complexity Δ
#unittests 90.61% <100.00%> (ø) 3530.00 <20.00> (ø)
Impacted Files Coverage Δ Complexity Δ
src/Core/Client/Adapter/TimeoutAwareTrait.php 50.00% <ø> (ø) 2.00 <0.00> (ø)
src/Core/Client/Adapter/Psr18Adapter.php 92.59% <100.00%> (ø) 23.00 <20.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ca9b8a...8bd32d1. Read the comment docs.

@mkalkbrenner
Copy link
Member

I think we can close this now as the docs are adjusted.

@thomascorthals thomascorthals deleted the psr18nonfinal branch June 10, 2020 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use of 'final' and 'private' in Psr18Adapter
3 participants