Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split light and dark color schemes #4

Closed
wants to merge 1 commit into from

Conversation

losingkeys
Copy link

That way someone can just use xrdb xresources/solarized-light instead
of editing the file in order to switch between light and dark themes

That way someone can just use `xrdb xresources/solarized-light` instead
of editing the file in order to switch between light and dark themes
@seletskiy
Copy link

Please, look at official specification (http://ethanschoonover.com/solarized#the-values), base colors should not be changed across light and dark variations. fg and bg links to this colors should be changed. It is not your mistake, it is mistake in this repo.

Take a look at my .Xresources:
https://github.com/seletskiy/dotfiles/blob/master/.Xresources.dark
https://github.com/seletskiy/dotfiles/blob/master/.Xresources.light

@losingkeys
Copy link
Author

So this repo should be changed to more closely match your setup? I think
that would make it easier to use with xrdb.

On Thu, Sep 12, 2013 at 1:11 AM, Stanislav Seletskiy <
notifications@github.com> wrote:

Please, look at official specification (
http://ethanschoonover.com/solarized#the-values), base colors should not
be changed across light and dark variations. fg and bg links to this colors
should be changed. It is not your mistake, it is mistake in this repo.

Take a look at my .Xresources:
https://github.com/seletskiy/dotfiles/blob/master/.Xresources.dark
https://github.com/seletskiy/dotfiles/blob/master/.Xresources.light


Reply to this email directly or view it on GitHubhttps://github.com//pull/4#issuecomment-24297160
.

@seletskiy
Copy link

@JoshuaRH: I'm just talking about that S_base03 and so on colors definitions should not be changed in different light modes. Looks closely at xresources file here. On line 20 we can see: #define S_base03 #002b36, but on line 32 it is defined as #define S_base03 #fdf6e3.

@mpalvig
Copy link

mpalvig commented Dec 17, 2013

I came to the exact same conclusion after a problem with vim-colors-solarized which reversed light and dark background when light colors were set in .Xresources. The example file should be changed to reflect your method, @seletskiy, so that color0-15 are unchanged by changing terminal background.

@TrevorBramble
Copy link
Member

Terribly sorry about this, everyone. Not only did I screw up the inverse color scheme (following some wording in the spec too literally) and @altercation trusted me too much to notice I'd misinterpreted it, but I've had the proper replacement and a script to generate both forms for months.

Will follow up on this as soon as I can. Thanks for your patience!

@juanibiapina
Copy link

It seems the version in the repo is still broken when using light colors, right?

@seletskiy version seems to be consistent.

@blueyed
Copy link
Contributor

blueyed commented Apr 9, 2015

@TrevorBramble
Ping. Can you fix this, please?

@blueyed
Copy link
Contributor

blueyed commented Apr 9, 2015

See altercation/solarized#68 for an attempt at using intermediate #defines.

@blueyed
Copy link
Contributor

blueyed commented Apr 11, 2015

@seletskiy
Just for info: I've used your files for a new PR: #6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants