Visual studio like tabs #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jirkapok
force-pushed
the
VisualStudio_Like_Tabs
branch
from
8cc9c82
to
fbf8a8c
Compare
|
I pulled this code and built it locally. It looks nice, but it crashes (access violation) if I try to drag a tab out of the window or dock it to the side. Does that work correctly for you? |
|
No, working on it, it crashes in the ScintillaNET WinProc method. Searching for workaround. |
|
It works now! I'd like Vit to also take a look before I merge this. |
|
This is a pretty sweet change. |
nothrow
approved these changes
Feb 28, 2018
| @@ -121,6 +121,8 @@ | |||
| <File Source="$(var.OutputDir)\SolarWinds.SDK.Swis.Contract.dll" /> | |||
| <File Source="$(var.OutputDir)\SolarWinds.Logging.dll" /> | |||
| <File Source="$(var.OutputDir)\Security.Cryptography.dll" /> | |||
| <File Source="$(var.OutputDir)\WeifenLuo.WinFormsUI.Docking.dll" /> | |||
There was a problem hiding this comment.
please, use same whitespace settings as for the rest of the file
|
Neat! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enhances the UI by adding possibility to dock multiple queries side by side.