Added documentation panel to the SWQL studio #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danjagnow
reviewed
Jul 22, 2019
| } | ||
| } | ||
|
|
||
| public static void RebuildVerbArguments(TreeNode verbNode, IMetadataProvider provider) |
There was a problem hiding this comment.
Could this be handled in AddVerbsToNode instead?
There was a problem hiding this comment.
No, it was designed as lazyloading
danjagnow
reviewed
Jul 22, 2019
| if (data is SwisMetaDataProvider) | ||
| return ProviderDocumentation(provider); | ||
|
|
||
| if (data is string nameSpace) |
There was a problem hiding this comment.
Should we have a class for namespaces? Is string sufficient?
There was a problem hiding this comment.
There is no logic behind the namespace now, is string is still enough
danjagnow
reviewed
Jul 22, 2019
| return builder.ToString(); | ||
| } | ||
|
|
||
| public static string ToNodeText(string name, int childsCount) |
There was a problem hiding this comment.
"children" instead of "childs"
danjagnow
approved these changes
Jul 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new panel below Object explorer in SWQL studio to show complete metadata documentation.
Currently the panel shows the same information like ToolTips, but in another formatting. In the future i want to add other documentation (e.g. access control list).