Response time OTel metric #223
Conversation
There was a problem hiding this comment.
LGTM, nice refactor/renaming to boot, thanks @raphael-theriault-swi! Not sure if you've ad-hoc tested to confirm that the histograms are indeed DELTA aggregation, I think Python and Java had to explicitly set that.
| transaction: string | undefined, | ||
| ) { | ||
| const method = span.attributes[SemanticAttributes.HTTP_METHOD] | ||
| const statusCode = span.attributes[SemanticAttributes.HTTP_STATUS_CODE] |
There was a problem hiding this comment.
Something I didn't even think about until now ;p -- does the JS lambda instrumentation always represent a lambda invocation as an HTTP server span, i.e. we always get the method and status_code? Back when adding support in AO it was a horror to find out the way a function is invoked produces different request context payload and only the "via API Gateway" (which now the Function URL makes easy) had HTTP type info in the payload.
Not a blocker for this PR, just curious.
There was a problem hiding this comment.
I'll need to double check
There was a problem hiding this comment.
Looks like these attributes are actually never set for Lambda spans at the moment
There was a problem hiding this comment.
OK, as discussed at standup the metric would just be tagged with whatever attributes are available then.
Adds the response time metric