Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Highlight improvements #227

Closed
PROPHESSOR opened this issue Mar 5, 2024 · 3 comments
Closed

[Feature Request] Highlight improvements #227

PROPHESSOR opened this issue Mar 5, 2024 · 3 comments
Labels
enhancement Enhancement to an existing feature
Milestone

Comments

@PROPHESSOR
Copy link

  • Dimm highlight colors for dark theme (they're so bright)
    image
  • Add more colors: blue, cyan, etc.
  • Add automatic highlights for some HEX pattern
  • Add more highlight methods: text color, background color, underline color, etc
@solemnwarning solemnwarning added the enhancement Enhancement to an existing feature label Apr 13, 2024
@solemnwarning solemnwarning added this to the 0.62.0 milestone Apr 13, 2024
@solemnwarning
Copy link
Owner

Which of these colour palette(s) do you prefer?

c100
c90
c80
c70

@cgarz
Copy link

cgarz commented May 23, 2024

70 looks the most readable and therefore best imo.
100 does look lovley, but less readable.

@solemnwarning
Copy link
Owner

I've made all the changes I'm planning on making to highlights for the next release:

  • Reduced default intensity of highlight colours when using dark colour schemes
  • Allow changing highlight colours, defining custom ones and assigning labels
  • Maintain file-specific lists of highlight colours/labels
  • Added shortcuts for assigning highlights (Ctrl+1,Ctrl+2,etc by default)

Please do open further issues if you still feel the need for the other changes once you've used the above for a little while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to an existing feature
Projects
None yet
Development

No branches or pull requests

3 participants