Skip to content
This repository has been archived by the owner on Jun 27, 2019. It is now read-only.

Conversation

gabrielschulhof
Copy link

This sacrifices our ability to build bindings against an existing soletta
installation identified by its pkgconfig file, because the pkgconfig file does
not contain information about the configuration options that were used when
building Soletta.

Signed-off-by: Gabriel Schulhof gabriel.schulhof@intel.com

Replaces #1775.

Changes since v1:

  • Liberally modify .config from bindings/nodejs/build-for-npm.sh, turning on node.js bindings, and, when building for debug, then also -g -O0, and turning off BUILD_TYPE_RELEASE and turning on BUILD_TYPE_DEBUG.

This sacrifices our ability to build bindings against an existing soletta
installation identified by its pkgconfig file, because the pkgconfig file does
not contain information about the configuration options that were used when
building Soletta.

Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
@ceolin
Copy link
Contributor

ceolin commented Mar 31, 2016

Soletta starts to build from the node bindings build ? That's the reason you change the .config manually to set DEBUG or RELEASE ? Also why are you setting these flags (-g -O0) ? It seems to be in the wrong place. Soletta's build should set this in debug mode.

@gabrielschulhof
Copy link
Author

@ceolin

Soletta starts to build from the node bindings build ? That's the reason you change the .config manually to set DEBUG or RELEASE ?

Yes. There are two use cases:

  1. You start with make <something>config and then you do make
  2. You start with npm install or npm install --debug

In the latter case it is assumed that you downloaded the package from the npm repository so there's no need to worry about make install, so RPATH is set and .config is modified to ensure the node.js bindings are built. Additionally, if --debug is specified, the release build is turned off and the debug build is turned on.

Also why are you setting these flags (-g -O0) ? It seems to be in the wrong place. Soletta's build should set this in debug mode.

BUILD_TYPE_DEBUG does not currently result in -O0 being added to the COMMON_CFLAGS. I will modify Makefile.vars to add -O0.

@gabrielschulhof gabrielschulhof deleted the nodejs-bindings-follow-config-settings-v2 branch April 8, 2016 08:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants