This repository has been archived by the owner on Jun 27, 2019. It is now read-only.
Node.js: Handle main loop interruption #1946
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielschulhof
force-pushed
the
nodejs-handle-nodejs-exit-simple
branch
from
780158d
to
52268e6
Compare
|
@nagineni this should make soletta handles behave just like node.js handles. So, if you don't clean them up and you handle SIGINT, it will hang. The only remaining shortcoming is that if you add a Does this fix your issue? |
gabrielschulhof
changed the title
gabrielschulhof
force-pushed
the
nodejs-handle-nodejs-exit-simple
branch
from
52268e6
to
94bbb7b
Compare
Also consolidates test helper files into a single directory. Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
gabrielschulhof
force-pushed
the
nodejs-handle-nodejs-exit-simple
branch
from
94bbb7b
to
db39b12
Compare
gabrielschulhof
changed the title
|
@gabrielschulhof Tested this locally and it works as you mentioned. Cleaning up soletta handles in SIGINT handler makes the process exit as expected. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also consolidates test helper files into a single directory.
Signed-off-by: Gabriel Schulhof gabriel.schulhof@intel.com
This does not yet include the signal handler chaining discussed in #1566 (comment), because this is a real issue causing busy loops sometimes.