This repository has been archived by the owner on Jun 27, 2019. It is now read-only.
vector: fix suboptimal sol_ptr_vector_del_element implementation v2 #2012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vladimir Cernov <cernov.vladimir@gmail.com>
kaspersky
changed the title
|
I have avoided copying elements in the same place without using an if statement: by having 2 for loops (first one finds first occurence, second one removes elements). |
|
+1 |
| while (i < pv->base.len && v[i] != elem) { | ||
| i++; | ||
| offset++; | ||
| } |
There was a problem hiding this comment.
I am going to suggest the tiniest of optimizations, feel totally free to ignore: do offset = i; after the while loop.
There was a problem hiding this comment.
@vcgomes , good observation, will do. Wonder how I didn't think of it myself.
|
Looking good. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vladimir Cernov cernov.vladimir@gmail.com