Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redefine behaviour of running solhint without a config file present #90

Closed
juanpcapurro opened this issue Dec 5, 2023 · 0 comments · Fixed by #135
Closed

redefine behaviour of running solhint without a config file present #90

juanpcapurro opened this issue Dec 5, 2023 · 0 comments · Fixed by #135
Labels
help wanted Extra attention is needed v4.0.0 breaking changes for next major version

Comments

@juanpcapurro
Copy link
Contributor

Currently, solhint errors out if there isn't any config file present (see e2e/tests.js)

I believe it'd a better experience for devs, and a simpler configuration for editor integrations, if solhint provided some good linting out-of the box

running solhint without a config file should

  • not exit with error
  • use recommended config

Input is appreciated on this.
@juanpcapurro juanpcapurro added help wanted Extra attention is needed v4.0.0 breaking changes for next major version labels Dec 5, 2023
juanpcapurro added a commit that referenced this issue Jan 29, 2024
@juanpcapurro
error out explicitly when extra config file passed via -c isnt found
737dee1 
code is duplicated in main action and listRules, but didn't see a really
good way modularize it yet. Perhaps when taking care of #90 or #133 it'll be
more evident?
juanpcapurro added a commit that referenced this issue Jan 29, 2024
@juanpcapurro
error out explicitly when extra config file passed via -c isnt found
9d6ae6d 
code is duplicated in main action and listRules, but didn't see a really
good way modularize it yet. Perhaps when taking care of #90 or #133 it'll be
more evident?
juanpcapurro added a commit that referenced this issue Jan 30, 2024
@juanpcapurro
error out explicitly when extra config file passed via -c isnt found
f249ee7 
code is duplicated in main action and listRules, but didn't see a really
good way modularize it yet. Perhaps when taking care of #90 or #133 it'll be
more evident?
@juanpcapurro juanpcapurro mentioned this issue Jan 30, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed v4.0.0 breaking changes for next major version
Projects
None yet
Milestone
No milestone
1 participant
@juanpcapurro