Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

running linter without a config file should use recommended config #135

Merged
merged 4 commits into from
Feb 4, 2024
Merged

running linter without a config file should use recommended config #135

merged 4 commits into from
Feb 4, 2024

Conversation

juanpcapurro
Copy link
Contributor

@juanpcapurro juanpcapurro commented Jan 30, 2024 •
edited
Loading

closes #90
merge after #134

  • print a warning on stderr
  • chug along with solhint:recommended config
  • stdin extra: crashes on inexistent file passed via -c
    • with other configs
    • without other configs
  • stdin extra: --filename can trigger using other config files!! already tested on e2e/configs-in-subdirectories
  • stdin: uses recommended config and prints a warning
  • move logic into loadFullConfigurationForPath to remove duplication

@juanpcapurro juanpcapurro changed the title running config without a config file should use recommended config running linter without a config file should use recommended config Jan 31, 2024
@juanpcapurro juanpcapurro force-pushed the 90-running-solhint-without-config branch 2 times, most recently from b6e12ef to f651577 Compare January 31, 2024 15:58
@juanpcapurro juanpcapurro marked this pull request as ready for review January 31, 2024 15:59
@juanpcapurro juanpcapurro marked this pull request as draft January 31, 2024 16:02
@juanpcapurro juanpcapurro force-pushed the 90-running-solhint-without-config branch 2 times, most recently from 1e07514 to a76755b Compare January 31, 2024 17:03
@juanpcapurro juanpcapurro marked this pull request as ready for review January 31, 2024 17:05
@juanpcapurro
use with recommended ruleset when linting without a config
4568db6 
We check explicitly for existence of files passed via -c, so the
behaviour of erroring out if they don't exist stays the same
@juanpcapurro
use recommended config when no config is available: stdin
8a01855 
code duplication is approaching escape velocity, also checking for
existence of explicit config file here
@juanpcapurro
update changelog
5a93462
@juanpcapurro
refactor logic into loadFullConfigurationForPath
7bb6abf 
did away with the nicer error messages for missing configs provided by
-c, instead chose to remove the redundant check + have unit tests for
its behaviour
@juanpcapurro juanpcapurro force-pushed the 90-running-solhint-without-config branch from a76755b to 7bb6abf Compare February 4, 2024 15:02
@juanpcapurro juanpcapurro merged commit 31597c1 into master Feb 4, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

redefine behaviour of running solhint without a config file present
1 participant
@juanpcapurro