Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications protocol #63

Merged
merged 34 commits into from
Oct 3, 2022
Merged

Notifications protocol #63

merged 34 commits into from
Oct 3, 2022

Conversation

michielbdejong
Copy link
Collaborator

Add tests for secure authenticated web socket notifications (required from spec v0.9.1, see solid-contrib/test-suite#149) and for Webhooks (optional)

@michielbdejong
Copy link
Collaborator Author

Developing this against https://github.com/pdsinterop/solid-nextcloud/blob/main/run-solid-test-suite.sh with

docker run --rm --network=testnet --env COOKIE="$COOKIE_server" --env COOKIE_ALICE="$COOKIE_server" --env COOKIE_BOB="$COOKIE_thirdparty" --env-file ./env-vars-testers.list -it -v /Users/michiel/gh/solid-contrib/solid-crud-tests:/app solid-crud-tests /bin/bash

@michielbdejong
Copy link
Collaborator Author

Ah! Entered a world of pain with jest module type whatever... better just mount only the test/ folder.

docker run --rm --network=testnet --env COOKIE="$COOKIE_server" --env COOKIE_ALICE="$COOKIE_server" --env COOKIE_BOB="$COOKIE_thirdparty" --env-file ./env-vars-testers.list -it -v /Users/michiel/gh/solid-contrib/solid-crud-tests/test:/app/test solid-crud-tests /bin/bash

@michielbdejong
Copy link
Collaborator Author

I'll also include solid-contrib/solid-auth-fetcher#33

@michielbdejong
Copy link
Collaborator Author

Running this in development against Solid-Nextcloud using the instructions from 'TODO.txt' in this branch.

@michielbdejong
Copy link
Collaborator Author

Adding env vars:

  • SKIP_SECURE_WEBSOCKETS
  • SKIP_WEBHOOKS

@michielbdejong
Copy link
Collaborator Author

Leaving the tests for the updates received over secure websocket notifications channel to follow-up ticket #65

@michielbdejong
Copy link
Collaborator Author

Rest is working! Merging and tagging a release, so we can start running it in CI against Solid-Nextcloud

@michielbdejong michielbdejong changed the title [WiP] Notifications protocol Notifications protocol Oct 3, 2022
@michielbdejong michielbdejong merged commit 3b64072 into main Oct 3, 2022
@michielbdejong michielbdejong deleted the notifications-protocol branch October 3, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant