-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebHookSubscription2022 subscription type #457
Comments
It will also have to be added in solid/vocab#62 and in https://github.com/solid/specification/blob/main/notification-subscription-types.html |
There is a client https://github.com/o-development/solid-webhook-client I see that solid/vocab#62 only includes |
For reference, here are our WIP implementation in Solid-Nextcloud and WIP tests in the Solid CRUD tests |
@michielbdejong is the major change you have around the content of the notification or around the notification method itself. If it's the former, I think that should be a part of the general notifications specification rather than something specific to to webhooks |
it's not a major change, note that the existing one is WebSocketSubscription2021 and the one that seems to be missing (unless we misunderstood) is WebHookSubscription2022. The difference 2021/2022 is just that I thought the template was to add the current year at the time of proposing each one? Or should all subscription type names end in 2021? |
Each subscription type spec should define IRI denoting it https://github.com/solid/notifications/blob/main/webhook-subscription-2021.md#1-introduction
I think the action here would be
Implementations should just rely on the full IRI. How we name the spec is not an exact science, IMO for this draft, either 2021 or 2022 works as long as it is used in a consistent way throughout the draft. The original proposal was created and migrated to its current repo back in 2021 solid/notifications#23 |
We've started experimenting with implementing webhooks. The notifications spec gives a pretty good description of how they should work, but doesn't specify an RDF class name for them.
To be able to add them as a second subscription type, next to
WebSocketSubscription2021
we were thinking of calling itWebHookSubscription2022
.Is anybody else working on webhooks already and maybe already using a different class name to announce them? If so, let's coordinate! :)
CC @jaxoncreed
The text was updated successfully, but these errors were encountered: